Commit graph

593 commits

Author SHA1 Message Date
Matt Willsher
e5df814ae6
Merge pull request #202 from richm/cl-20220831
Version v0.17.0 - CHANGELOG.md [citest skip]
2022-09-07 08:26:15 +01:00
Rich Megginson
606ed47dd1 Version v0.17.0 - CHANGELOG.md [citest skip]
[v0.17.0] - 2022-08-31
--------------------

- Make drop-in config file functionality configurable by user

This PR simplifies the logic behind the drop-in config files and also
allows the user to use drop-in configs even if the distribution does not
support it out of the box.

- Allow user to override variables

A previous commit hardcoded many variables to the values under vars/,
making it impossible for the user to parameterize things like the systemd
service name. The assumption was that the __sshd_* variables were useless
in an effort to blindly adhere to best practices, but they were crucial in
allowing flexibility to the user.

- none
2022-09-01 07:27:24 -06:00
Matt Willsher
1731328cc5
Merge pull request #200 from nkakouros/drop-in 2022-08-29 09:59:16 +01:00
Nikolaos Kakouros
6bb0d7b456 tMakes drop-in functionality configurable by the user 2022-08-26 20:23:51 +00:00
Nikolaos Kakouros
5f67c9b3d2 Backups relevant files 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
735afa580c Address comment 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
7866c6bc29 Fix tests 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
221a801260 Adds workaround for CentOS6 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
c8d7c25be3 Defaults __sshd_testing when not testing 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
d2b274a0a1 Fixes tests 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
87ed3d4c15 Addresses comments and linters 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
db39a733aa Moves internal non-overridable variables out of defaults 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
d5b2f8df02 Adds tests for duplicate role use 2022-08-23 15:18:41 +02:00
Nikolaos Kakouros
4e22a9618d Fixes un-overrideable public api variables 2022-08-23 15:18:41 +02:00
Matt Willsher
f1d7198a2b
Merge pull request #201 from richm/auto-cl-tag-release-fix
parse [vX.Y.Z] correctly from CHANGELOG.md
2022-08-22 09:00:57 +01:00
Richard Megginson
c1e41b5b1a
remove galaxy publish
remove the publish-to-galaxy task
2022-08-20 09:54:49 -06:00
Rich Megginson
91b97deb1c parse [vX.Y.Z] correctly from CHANGELOG.md 2022-08-18 07:26:09 -06:00
Matt Willsher
b75ef4c630
Merge pull request #195 from richm/cl-20220728
Version v0.16.1 - CHANGELOG.md [citest skip]
2022-08-18 09:13:09 +01:00
Jakub Jelen
77d3163243 Workaround for https://github.com/ansible/ansible-lint/issues/2209
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
2022-08-18 09:08:53 +02:00
Jakub Jelen
08285659ed Fix ansible-lint warnings
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
2022-08-18 09:08:53 +02:00
Rich Megginson
33f94e45a6 Version v0.16.1 - CHANGELOG.md [citest skip]
[v0.16.1] - 2022-07-28
--------------------

- add parameter RSAMinSize

Add support for the new RSAMinSize parameter.

- Ensure values are cast to correct type

- Addition notes about secondary variables
- Fix various linting issues
- Revert incorrect module name
- tests: Do not be picky about spaces/tabs

When testing with cloud-init, it modifies the sshd_configuration and can
replace some tabs with whitespaces. This happens frequently around the
subsystem keyword. There are no functional changes, but the matching
did not work as expected.

Signed-off-by: Jakub Jelen <jjelen@redhat.com>

- the role still supports ansible 2.9

- Add CHANGELOG.md

- Add changelog_to_tag.yml to .github/workflows

Description:
When a new changelog section is added to CHANGELOG.md and pushed,
changelog_to_tag.yml is triggered, which generates a new tag and
a new release.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
2022-08-16 07:40:46 -06:00
Rich Megginson
67d2339f03 Ensure values are cast to correct type
https://github.com/willshersystems/ansible-sshd/issues/188
This shouldn't be necessary, but there seems no way to
guarantee using a version of Jinja which doesn't have this
problem.

In addition - it is not good practice to compare values to
`true` or `false` - instead, just ensure the value is a `bool`
type and evaluate in a boolean context.
2022-08-16 08:36:57 +02:00
Matt Willsher
9766d9097a
Merge pull request #196 from richm/add-RSAMinSize-2 2022-07-29 09:54:24 +01:00
Rich Megginson
1bc8395ea8 Add parameter RSAMinSize to Match blocks
This is a follow-on to https://github.com/willshersystems/ansible-sshd/pull/194
The previous PR added RSAMinSize as an option for the "body" of the
config file, but not for Match blocks.
2022-07-28 15:43:35 -06:00
Matt Willsher
9f3eb191ea
Merge pull request #194 from richm/add-RSAMinSize 2022-07-28 15:08:03 +01:00
Matt Willsher
841a6ef9e4
Merge pull request #193 from nhosoi/tag_release 2022-07-22 02:38:25 +01:00
Matt Willsher
30f03bbd8d
Merge pull request #192 from nhosoi/changelog 2022-07-22 02:37:00 +01:00
Rich Megginson
6c0ff316af add parameter RSAMinSize
Add support for the new RSAMinSize parameter.
2022-07-21 15:35:57 -06:00
Noriko Hosoi
65fe227276 Add changelog_to_tag.yml to .github/workflows
Description:
When a new changelog section is added to CHANGELOG.md and pushed,
changelog_to_tag.yml is triggered, which generates a new tag and
a new release.

Example of CHANGELOG.md changes:
  [v9.9.9] - 2022-12-31
  --------------------

  ### New features

  - New feature A

  ### Bug fixes

  - Bug fix B

Using this example, when the commit on CHANGELOG.md is pushed, a
new tag "v9.9.9" is added and Version v9.9.9 is released in github.
If tag "v9.9.9" already exists, the CHANGELOG.md push fails.

Signed-off-by: Noriko Hosoi <nhosoi@redhat.com>
2022-07-21 13:48:50 -07:00
Noriko Hosoi
0c22107a32 Add CHANGELOG.md
- Each changelog has 3 sections, "### New Features", "### Bug Fixes",
  and "Other Changes".
- If there is no items in a section, let it have "- none".
2022-07-07 13:15:28 -07:00
Matt Willsher
7349bd448e
Merge pull request #191 from richm/meta-29 2022-06-15 23:09:30 +01:00
Rich Megginson
4ca9e8f142 the role still supports 2.9 2022-06-14 07:40:52 -06:00
Jakub Jelen
61cce32ce6 tests: Do not be picky about spaces/tabs
When testing with cloud-init, it modifies the sshd_configuration and can
replace some tabs with whitespaces. This happens frequently around the
subsystem keyword. There are no functional changes, but the matching
did not work as expected.

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
2022-06-13 17:28:34 +02:00
Matt Willsher
e45987e3c7
Merge pull request #189 from willshersystems/docs-update 2022-06-06 10:19:26 +01:00
Matt Willsher
54e5b69d55 Fix various linting issues 2022-06-05 09:18:15 +01:00
Matt Willsher
8e39178751 Fix various linting issues 2022-06-05 09:03:05 +01:00
Matt Willsher
57c46b6587 Fix various linting issues 2022-06-05 09:00:47 +01:00
Matt Willsher
477daa032f Fix various linting issues 2022-06-05 08:57:58 +01:00
Matt Willsher
af7230cf29 Fix various linting issues 2022-06-05 08:54:56 +01:00
Matt Willsher
b9c5db54b6 Revert incorrect module name 2022-06-03 11:30:13 +01:00
Matt Willsher
90338a3f0a Fix various linting issues 2022-06-03 11:22:17 +01:00
Matt Willsher
dc350e600f
Addition notes about secondary variables 2022-06-02 12:38:25 +01:00
Matt Willsher
0f7b222e13
Merge pull request #187 from Jakuje/remove-kvm
Remove kvm from virtualization platforms, update dependency.
2022-06-02 12:21:03 +01:00
Jakub Jelen
97bd62a387 Remove kvm from skipped environments 2022-05-25 09:02:28 +02:00
Jakub Jelen
19cf7e9a3c CI: Revert back to upstream roles after the git issues are fixed 2022-05-19 09:49:42 +02:00
Jakub Jelen
753073f4d6 ci: Use the same workaround for unsafe directory in Fedora 2022-05-10 16:48:22 +02:00
Jakub Jelen
74026ba2f8 Add support for Ubuntu 22 with drop-in directory
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
2022-05-10 16:48:22 +02:00
Jakub Jelen
051f5666b2 Test solution for unsafe dir on latest ubuntu
https://github.com/roles-ansible/check-ansible-ubuntu-latest-action/pull/2
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
2022-05-10 16:48:22 +02:00
Jakub Jelen
dd5f79e5f0 tests: Verify os defaults are used also if the drop-in directory exists
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
2022-05-10 16:48:22 +02:00
Jakub Jelen
fe69a54f4e CI: Add older Ubuntu versions to CI too
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
2022-05-10 16:48:22 +02:00