libretic/etherpad-lite
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

pad: Don't paste when middle-clicking on a link

Browse source
This commit is contained in:
Richard Hansen 2020-10-24 20:14:04 -04:00 committed by John McLear
parent bee1ae06d8
commit 193028702d
1 changed files with 30 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
src/static/js/ace2_inner.js
View file

@ -4788,13 +4788,37 @@ function Ace2Inner(){
} }
if (browser.msie) $(root).on("paste", handleIEPaste); if (browser.msie) $(root).on("paste", handleIEPaste);
// Don't paste on middle click of links // If non-nullish, pasting on a link should be suppressed.
let suppressPasteOnLink = null;
$(root).on('auxclick', function(e) {
if (e.originalEvent.button === 1 && (e.target.a || e.target.localName === 'a')) {
// The user middle-clicked on a link. Usually users do this to open a link in a new tab, but
// in X11 (Linux) this will instead paste the contents of the primary selection at the mouse
// cursor. Users almost certainly do not want to paste when middle-clicking on a link, so
// tell the 'paste' event handler to suppress the paste. This is done by starting a
// short-lived timer that suppresses paste (when the target is a link) until either the
// paste event arrives or the timer fires.
//
// Why it is implemented this way:
// * Users want to be able to paste on a link via Ctrl-V, the Edit menu, or the context
// menu (https://github.com/ether/etherpad-lite/issues/2775) so we cannot simply
// suppress all paste actions when the target is a link.
// * Non-X11 systems do not paste when the user middle-clicks, so the paste suppression
// must be self-resetting.
// * On non-X11 systems, middle click should continue to open the link in a new tab.
// Suppressing the middle click here in the 'auxclick' handler (via e.preventDefault())
// would break that behavior.
suppressPasteOnLink = scheduler.setTimeout(() => { suppressPasteOnLink = null; }, 0);
}
});
$(root).on("paste", function(e){ $(root).on("paste", function(e){
// TODO: this breaks pasting strings into URLS when using if (suppressPasteOnLink != null && (e.target.a || e.target.localName === "a")) {
// Control C and Control V -- the Event is never available scheduler.clearTimeout(suppressPasteOnLink);
// here.. :( suppressPasteOnLink = null;
if(e.target.a || e.target.localName === "a"){ e.preventDefault();
// e.preventDefault(); // Disabled due to https://github.com/ether/etherpad-lite/issues/2775 return;
} }
// Call paste hook // Call paste hook