libretic/etherpad-lite
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Abiword: Use the async-provided callback to signal errors

Browse source 
This avoids having two callbacks, which improves readability.
This commit is contained in:
Richard Hansen 2021-03-17 19:14:36 -04:00 committed by John McLear
parent 8d32463915
commit 5eab3a123d
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/node/utils/Abiword.js
View file

@ -77,17 +77,15 @@ if (os.type().indexOf('Windows') > -1) {
};
spawnAbiword();
doConvertTask = (task, callback) => {
const queue = async.queue((task, callback) => {
abiword.stdin.write(`convert ${task.srcFile} ${task.destFile} ${task.type}\n`);
stdoutCallback = (err) => {
callback();
if (err != null) console.error('Abiword File failed to convert', err);
task.callback(err);
callback(err);
};
};
}, 1);
const queue = async.queue(doConvertTask, 1);
exports.convertFile = (srcFile, destFile, type, callback) => {
queue.push({srcFile, destFile, type, callback});
queue.push({srcFile, destFile, type}, callback);
};
}