From 8e4c961207bb995a61c94407c11efb298e5f3157 Mon Sep 17 00:00:00 2001 From: Stefan Date: Fri, 10 Apr 2015 23:52:17 +0200 Subject: [PATCH 1/2] Add version number to plugins-info page --- src/node/hooks/express/adminplugins.js | 8 +++++++- src/node/utils/Settings.js | 1 - src/templates/admin/plugins-info.html | 5 +++-- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/node/hooks/express/adminplugins.js b/src/node/hooks/express/adminplugins.js index 5015cc5a..c49d6621 100644 --- a/src/node/hooks/express/adminplugins.js +++ b/src/node/hooks/express/adminplugins.js @@ -4,6 +4,7 @@ var installer = require('ep_etherpad-lite/static/js/pluginfw/installer'); var plugins = require('ep_etherpad-lite/static/js/pluginfw/plugins'); var _ = require('underscore'); var semver = require('semver'); +var epVersion = require('ep_etherpad-lite/package.json').version; exports.expressCreateServer = function (hook_name, args, cb) { args.app.get('/admin/plugins', function(req, res) { @@ -17,7 +18,12 @@ exports.expressCreateServer = function (hook_name, args, cb) { }); args.app.get('/admin/plugins/info', function(req, res) { var gitCommit = settings.getGitCommit(); - res.send( eejs.require("ep_etherpad-lite/templates/admin/plugins-info.html", {gitCommit:gitCommit}) ); + res.send( eejs.require("ep_etherpad-lite/templates/admin/plugins-info.html", + { + gitCommit: gitCommit, + epVersion: epVersion + }) + ); }); } diff --git a/src/node/utils/Settings.js b/src/node/utils/Settings.js index 536c088b..07f5055c 100644 --- a/src/node/utils/Settings.js +++ b/src/node/utils/Settings.js @@ -199,7 +199,6 @@ exports.getGitCommit = function() { var refPath = rootPath + "/.git/" + ref.substring(5, ref.indexOf("\n")); version = fs.readFileSync(refPath, "utf-8"); version = version.substring(0, 7); - console.log("Your Etherpad git version is " + version); } catch(e) { diff --git a/src/templates/admin/plugins-info.html b/src/templates/admin/plugins-info.html index 1b328a89..5d39c388 100644 --- a/src/templates/admin/plugins-info.html +++ b/src/templates/admin/plugins-info.html @@ -22,8 +22,9 @@
-

Etherpad Git Commit

-

<%= gitCommit %>

+

Etherpad version

+

Version number: <%= epVersion %>

+

Git sha: <%= gitCommit %>

Installed plugins

<%- plugins.formatPlugins().replace(", ","\n") %>
From db5bdc87194cc8a790dd9d7cd656b72d42c5f285 Mon Sep 17 00:00:00 2001 From: Stefan Date: Sat, 11 Apr 2015 00:13:04 +0200 Subject: [PATCH 2/2] Log version number and git-sha on server start --- src/node/hooks/express.js | 2 ++ src/node/hooks/express/adminplugins.js | 2 +- src/node/utils/Settings.js | 5 +++++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/node/hooks/express.js b/src/node/hooks/express.js index 3275bd3f..bf849419 100644 --- a/src/node/hooks/express.js +++ b/src/node/hooks/express.js @@ -13,6 +13,8 @@ exports.createServer = function () { console.log("Report bugs at https://github.com/ether/etherpad-lite/issues") serverName = "Etherpad " + settings.getGitCommit() + " (http://etherpad.org)"; + + console.log("Your Etherpad version is " + settings.getEpVersion() + " (" + settings.getGitCommit() + ")"); exports.restartServer(); diff --git a/src/node/hooks/express/adminplugins.js b/src/node/hooks/express/adminplugins.js index c49d6621..1ae8d7b5 100644 --- a/src/node/hooks/express/adminplugins.js +++ b/src/node/hooks/express/adminplugins.js @@ -4,7 +4,6 @@ var installer = require('ep_etherpad-lite/static/js/pluginfw/installer'); var plugins = require('ep_etherpad-lite/static/js/pluginfw/plugins'); var _ = require('underscore'); var semver = require('semver'); -var epVersion = require('ep_etherpad-lite/package.json').version; exports.expressCreateServer = function (hook_name, args, cb) { args.app.get('/admin/plugins', function(req, res) { @@ -18,6 +17,7 @@ exports.expressCreateServer = function (hook_name, args, cb) { }); args.app.get('/admin/plugins/info', function(req, res) { var gitCommit = settings.getGitCommit(); + var epVersion = settings.getEpVersion(); res.send( eejs.require("ep_etherpad-lite/templates/admin/plugins-info.html", { gitCommit: gitCommit, diff --git a/src/node/utils/Settings.js b/src/node/utils/Settings.js index 07f5055c..7e0e6c5a 100644 --- a/src/node/utils/Settings.js +++ b/src/node/utils/Settings.js @@ -207,6 +207,11 @@ exports.getGitCommit = function() { return version; } +// Return etherpad version from package.json +exports.getEpVersion = function() { + return require('ep_etherpad-lite/package.json').version; +} + exports.reloadSettings = function reloadSettings() { // Discover where the settings file lives var settingsFilename = argv.settings || "settings.json";