libretic/etherpad-lite
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

select: remove nice-select for safari because of a known bug with fixed position and overflow

Browse source 
Make the safari select looks the same than for other browser
Only the dropdown will be different
This commit is contained in:
Sebastian Castro 2020-04-28 15:25:03 +02:00 committed by muxator
parent 23307d14d5
commit af67f02da2
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/static/css/pad/form.css
View file

@ -32,9 +32,6 @@ select, .nice-select {
.nice-select:hover {
border-color: #dbdbdb;
}
.nice-select:active,.nice-select.open,.nice-select:focus {
/*border-color: #999;*/
}
.nice-select:after {
border-bottom: 2px solid #999;
border-right: 2px solid #999;

11
src/static/js/pad_editbar.js
View file

@ -20,6 +20,7 @@
* limitations under the License.
*/
var browser = require('./browser');
var hooks = require('./pluginfw/hooks');
var padutils = require('./pad_utils').padutils;
var padeditor = require('./pad_editor').padeditor;
@ -170,7 +171,15 @@ var padeditbar = (function()
ace: padeditor.ace
});
$('select').niceSelect();
/*
* On safari, the dropdown in the toolbar gets hidden because of toolbar
* overflow:hidden property. This is a bug from Safari: any children with
* position:fixed (like the dropdown) should be displayed no matter
* overflow:hidden on parent
*/
if (!browser.safari) {
$('select').niceSelect();
}
// When editor is scrolled, we add a class to style the editbar differently
$('iframe[name="ace_outer"]').contents().scroll(function() {