From cfdd57b48754ac34819c05150e1677aa2c7613ff Mon Sep 17 00:00:00 2001 From: Simon Gaeremynck Date: Wed, 19 Feb 2014 10:48:15 +0000 Subject: [PATCH] Addressed a potential never finishing forEach in PadMessageHandler.padUsers If the session info for a client would be null or undefined, the forEach callback would never get called which means the padUsers callback would never get trigged. This could potentially block API request as this function is exposed at an HTTP API endpoint. --- src/node/handler/PadMessageHandler.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/node/handler/PadMessageHandler.js b/src/node/handler/PadMessageHandler.js index 774ebf08..ed47109d 100644 --- a/src/node/handler/PadMessageHandler.js +++ b/src/node/handler/PadMessageHandler.js @@ -1570,6 +1570,8 @@ exports.padUsers = function (padID, callback) { result.push(author); callback(); }); + } else { + callback(); } }, function(err) { if(ERR(err, callback)) return;