libretic
/
etherpad-lite
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PadMessageHandler: Convert complex `if` to `switch`

This commit is contained in:
Richard Hansen 2022-02-22 22:41:55 -05:00
parent 05dd9920c5
commit fcfa51bda6
1 changed files with 31 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/node/handler/PadMessageHandler.js
View File

@ -329,33 +329,37 @@ exports.handleMessage = async (socket, message) => {
} }
// Check what type of message we get and delegate to the other methods // Check what type of message we get and delegate to the other methods
if (message.type === 'CLIENT_READY') { switch (message.type) {
await handleClientReady(socket, message); case 'CLIENT_READY': await handleClientReady(socket, message); break;
} else if (message.type === 'CHANGESET_REQ') { case 'CHANGESET_REQ': await handleChangesetRequest(socket, message); break;
await handleChangesetRequest(socket, message); case 'COLLABROOM':
} else if (message.type === 'COLLABROOM') { if (readOnly) {
if (readOnly) { messageLogger.warn('Dropped message, COLLABROOM for readonly pad');
messageLogger.warn('Dropped message, COLLABROOM for readonly pad'); break;
} else if (message.data.type === 'USER_CHANGES') { }
stats.counter('pendingEdits').inc(); switch (message.data.type) {
await padChannels.enqueue(thisSession.padId, {socket, message}); case 'USER_CHANGES':
} else if (message.data.type === 'USERINFO_UPDATE') { stats.counter('pendingEdits').inc();
await handleUserInfoUpdate(socket, message); await padChannels.enqueue(thisSession.padId, {socket, message});
} else if (message.data.type === 'CHAT_MESSAGE') { break;
await handleChatMessage(socket, message); case 'USERINFO_UPDATE': await handleUserInfoUpdate(socket, message); break;
} else if (message.data.type === 'GET_CHAT_MESSAGES') { case 'CHAT_MESSAGE': await handleChatMessage(socket, message); break;
await handleGetChatMessages(socket, message); case 'GET_CHAT_MESSAGES': await handleGetChatMessages(socket, message); break;
} else if (message.data.type === 'SAVE_REVISION') { case 'SAVE_REVISION': await handleSaveRevisionMessage(socket, message); break;
await handleSaveRevisionMessage(socket, message); case 'CLIENT_MESSAGE': {
} else if (message.data.type === 'CLIENT_MESSAGE' && const {type} = message.data.payload || {};
message.data.payload != null && switch (type) {
message.data.payload.type === 'suggestUserName') { case 'suggestUserName': handleSuggestUserName(socket, message); break;
handleSuggestUserName(socket, message); default: messageLogger.warn(
} else { `Dropped message, unknown COLLABROOM CLIENT_MESSAGE type: ${type}`);
messageLogger.warn(`Dropped message, unknown COLLABROOM Data Type ${message.data.type}`); }
} break;
} else { }
messageLogger.warn(`Dropped message, unknown Message Type ${message.type}`); default:
messageLogger.warn(`Dropped message, unknown COLLABROOM Data Type ${message.data.type}`);
}
break;
default: messageLogger.warn(`Dropped message, unknown Message Type ${message.type}`);
} }
}; };