cd4f5ff281
pad: Defer message handling until handshake completes
2021-10-29 19:37:28 -04:00
be0298290d
pad: Move post-handshake code to `_afterHandshake()`
2021-10-29 19:27:33 -04:00
9fb754ce3a
pad: Initialize pad cookie before starting the handshake
2021-10-29 19:27:33 -04:00
f6c5ce606e
pad: Move UI setup from `handshake()` to `init()`
2021-10-29 19:27:33 -04:00
bd44a87388
pad: Unexport unnecessarily exported `handshake()` function
2021-10-29 19:27:33 -04:00
5cbbcbcee6
pad: Simplify reload after `.etherpad` import
...
The old "switch to pad" logic looked buggy, and it complicates pad
initialization. Forcing a refresh after importing an `.etherpad` file
isn't much of a UX downgrade.
2021-10-29 19:27:33 -04:00
e974622561
pad: Use `window.` to avoid ESLint error
2021-10-29 19:27:33 -04:00
d8ca3a693d
timeslider scrollTo: fixes wrong line number calculation in case there
...
are no attribute changes and no length changes
2021-10-29 02:38:29 -04:00
de3dfb5ce2
AttributePool: Add JSDoc comments
2021-10-24 21:18:56 -04:00
c98b521539
AttributePool: Use ES6 class syntax
2021-10-24 21:18:56 -04:00
bbc8b29ffd
Changeset: Improve JSDoc comments
...
Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-10-24 21:18:56 -04:00
788eb86d84
Ace2Inner: Inline code that is unnecessarily inside an IIFE
2021-10-07 19:53:40 -04:00
4890cd8972
Ace2Inner: Delete completed TODO comment
2021-10-07 19:53:40 -04:00
044f6543a5
lint: Fix ESLint errors (mostly camelcase warnings)
2021-10-07 19:53:40 -04:00
34cfff4e4c
Changeset: Delete unused code
2021-10-07 19:53:40 -04:00
eb495e9ea2
Changeset: Move out obsolete code
2021-10-07 19:53:40 -04:00
c361df52d2
bugfix: Allow selection to start/end before line marker
2021-10-02 02:41:58 -04:00
37a33042d2
ace2_inner: Improve rep documentation
2021-10-02 02:10:07 -04:00
4d8ae3475d
Changeset: Add documentation for `textLinesMutator()`
2021-09-30 12:29:24 +02:00
4d2839457a
CSS: Fix underscore and clear authorship icon alignment
2021-09-26 12:07:56 +02:00
7dbd278d1d
deps: Bump js-cookie to 3.0.0
2021-08-29 23:36:48 -04:00
0d65dc8a44
pad: Add `clientVars` to `postAceInit` hook context
...
This allows plugins to avoid the `clientVars` global variable.
2021-08-25 14:59:17 -04:00
fed950e809
ace2_inner: Simplify handler for Ctrl-@ (show authors)
2021-08-16 00:34:30 -04:00
88057eade2
ace2_inner: Readability improvements
2021-08-16 00:34:30 -04:00
bc6428025a
ace2_inner: Use for..of iteration to improve readability
2021-08-16 00:34:30 -04:00
f06307cb4c
ace2_inner: Fix for..in iteration
...
See commit c38c34bef4
2021-08-16 00:34:30 -04:00
2d50a8aa95
ace2_inner: Fix efficiency of `rangeForLine()`
...
Returning `true` or `false` has no effect when iterating using
`Array.prototype.forEach`. This fixes a bug introduced in commit
b28bfe8e31
2021-08-16 00:34:30 -04:00
ca2e008e7b
ace2_inner: Move variable declarations to appropriate scope
2021-08-16 00:34:30 -04:00
bf10e70f2e
ace2_inner: Delete unnecessary `currentLine` variable
2021-08-16 00:34:30 -04:00
9fc613d362
ace2_inner: Delete unnecessary checks
2021-08-16 00:34:30 -04:00
a5f9c60a34
ace2_inner: Operate on Elements, not Nodes
2021-08-16 00:34:30 -04:00
aad75e4661
ace2_inner: Factor out duplicate line number div creation
2021-08-16 00:34:30 -04:00
3237f8d123
ace2_inner: Simplify iteration over line number divs
2021-08-16 00:34:30 -04:00
b238d9610a
ace2_inner: Factor out duplicate line height application
2021-08-16 00:34:30 -04:00
1b890e3d4d
ace2_inner: Replace `lineNumbersShown` with number of children
2021-08-16 00:34:30 -04:00
27363bf729
ace2_inner: Add line number divs directly, not via fragment
...
There's no layout thrashing so the fragment doesn't provide any
benefit.
2021-08-16 00:34:30 -04:00
e1a024847c
ace2_inner: Delete unnecessary `innerdocbody` variable
2021-08-16 00:34:30 -04:00
7d807d2fc5
ace2_inner: Delete unnecessary `container` variable
2021-08-16 00:34:30 -04:00
4b4584c264
ace2_inner: Delete unnecessary `doc` and `root` variables
2021-08-16 00:34:25 -04:00
ec63c15a40
ace2_inner: Simplify document body selection
2021-08-16 00:31:09 -04:00
11c86e677a
ace2_inner: Consistently use `outerWin` and `outerDoc`
2021-08-16 00:31:09 -04:00
98c1ba5808
ace2_inner: Use destructuring assignment to simplify
2021-08-16 00:31:09 -04:00
c7be4f9d2d
ace2_inner: Move `sidedivinner` creation to ace.js
2021-08-16 00:31:09 -04:00
15b1d4cb75
ace2_inner: Build `sidedivinner` programmatically
2021-08-16 00:31:09 -04:00
b80295c228
ace2_inner: Combine declaration and initialization
2021-08-16 00:31:09 -04:00
7a8edc816b
ace2_inner: Replace `initLineNumbers()` with an IIFE
2021-08-16 00:31:09 -04:00
b5bfff43cf
ace2_inner: Delete redundant class assignment
2021-08-16 00:31:08 -04:00
e581ee01f2
ace2_inner: Formatting improvements
2021-08-16 00:30:50 -04:00
0ca5a3459f
Timeslider: Install an error handler
2021-08-14 07:44:05 -04:00
b6fba9d66d
Pad: Improve page load error handler
...
* Install the error handler early.
* Include stack trace.
* Remove unnecessary escaping.
* Improve formatting.
* Move to a separate script file.
2021-08-14 07:44:05 -04:00
4a1f21ce34
pad_editbar: Convert snake case to camel case
2021-08-14 07:26:31 -04:00
5478d2ce60
pad_editbar: Use ES6 class syntax for readability
2021-08-14 07:26:31 -04:00
97ccf9e082
pad_editbar: Factor out duplicate code
2021-08-14 07:08:57 -04:00
ee41de4809
pad_editbar: Deprecate the `toggleDropDown` callback
2021-08-14 07:08:57 -04:00
c629ee09a8
pad_editbar: Call the callback asynchronously
...
This follows JavaScript best practices.
2021-08-14 07:08:57 -04:00
148e10821b
pad_editbar: Always call the callback
2021-08-14 07:08:57 -04:00
07e05a92eb
pad_editbar: Call the callback after all work is done
2021-08-14 07:08:57 -04:00
a1b924f746
pad_editbar: Don't pass a callback to `toggleDropDown()`
...
The function is synchronous so there's no point.
2021-08-14 07:08:57 -04:00
59d6a8b321
pad_editbar: Delete unnecessary `returned` variable
2021-08-14 07:01:50 -04:00
a4652d67a0
pad_editbar: Move `commands` up for readability
2021-08-14 07:01:50 -04:00
fda34407f9
pad_editbar: Move `dropdowns` initialization to constructor
...
This avoids null dereference if a buggy caller calls
`toggleDropDown('none')` before `init()`. (Ideally the caller would be
fixed, but this is not always feasible.)
2021-08-14 07:01:34 -04:00
42b0b1bf00
pad_editbar: Move `syncAnimation` out of `padeditbar` IIFE
...
This avoids the need for an IIFE.
2021-08-14 07:01:13 -04:00
ee996f530f
pad_editbar: Remove unnecessary `syncAnimationFn` variable
2021-08-14 07:01:13 -04:00
4b4eef5f4a
pad_editbar: Convert `registerDefaultCommands()` into a method
2021-08-14 07:01:13 -04:00
0d4f147349
pad_editbar: Simplify iteration
2021-08-14 07:01:13 -04:00
11faf6104a
pad_editbar: Convert `bodyKeyEvent()` into a method
2021-08-14 07:01:13 -04:00
b2fe6e3e7e
pad_editbar: Fix invalid use of `this`
2021-08-14 07:01:12 -04:00
b884628a5a
pad_editbar: Use arrow functions for callbacks, IIFEs
2021-08-14 07:01:12 -04:00
bdaa66c346
pad_editbar: Use `this` instead of `self`
2021-08-14 07:01:12 -04:00
c816c20bc7
HTML import: Replace cheerio with jsdom to simplify contentcollector
...
Cheerio provides jQuery-like objects but they wrap DOM Node-like
objects that are not 100% API compatible with the DOM spec. Because of
this, contentcollector, which is used in browsers and in Node.js
during HTML import, has until now needed to support two different
APIs. This commit modifies HTML import to use jsdom instead of cheerio
and simplifies contentcollector.
2021-08-12 13:53:23 -04:00
84d6d277d7
Accessibility fix for JAWS screen readers
...
ace.js: removed the role 'application' from innerDocument.body. JAWS
do not read any text from the edit lines if this role is set.
domline.createDomLine: to give JAWS the ability to read the lines
correctly, it is required to set the attribute 'aria-live' to
'assertive'.
2021-08-12 13:48:08 -04:00
e61888dfe2
ace.js: Don't use srcdoc when creating iframes (see #4975 )
...
Using srcdoc, especially with multiple nested iframes, seems to be
problematic when using `self` in CSP policies.
2021-07-30 03:51:57 -04:00
9fda5adcef
ace2_inner.js: Improve discovery of `sidediv` and `linemetricsdiv`
...
The `Node.nextSibling` property returns the next Node, not the next
Element. If whitespace, an HTML comment, or any other type of
non-Element Node is ever introduced between the Elements then
`.nextSibling` no longer returns the desired Element. Switching to
`Element.nextElementSibling` would work, but finding the Elements by
ID is more readable and future-proof.
2021-07-30 03:51:56 -04:00
0c963a817a
ace2_inner.js: Delete unnecessary `ace_outerWin` variable
2021-07-30 03:51:56 -04:00
8d869ec927
Pad: Delete non-functional debug logging facility
2021-07-30 03:50:23 -04:00
5d39a57507
Pad: Delete dead `ace_getFormattedCode()`
2021-07-30 03:49:35 -04:00
4ceb3ca4c8
Chat: Allow Shift-Enter to insert a newline
2021-07-19 23:44:33 +02:00
cf86ae8b63
Chat: Use `KeyboardEvent.key` instead of deprecated `.which`
2021-07-19 23:44:33 +02:00
faf84f0143
Chat: Display whitespace in chat messages
2021-07-19 23:44:33 +02:00
834e05fc9c
Chat: Use a `<textarea>` for message input
2021-07-19 23:44:33 +02:00
ca4cc2d7c0
Fix settings.useMonospaceFontGlobal
...
When settings.useMonospaceFontGlobal is set to `true`, it sets the default
font to 'monospace'. This font seems to have been removed in
a5164dad43
2021-07-14 04:33:38 -04:00
336d48add7
Add support for square brackets in URLs
...
This reverts commit 9022877cc6
2021-07-10 22:22:31 -04:00
5f39a1ee7f
CSS: Underline links in error dialogs
...
Underlining was removed for unknown reasons by commit
d872b42e31
2021-07-09 18:43:13 -04:00
3d40ab7e8c
CSS: Move author color padding to `setAuthorStyle()`
...
This prevents the padding from clashing with plugins that use the
`aceSetAuthorStyle` hook.
2021-06-22 14:43:22 -04:00
9fcd86b3cd
Pad: Fix `<script>` elements in `aceInitInnerdocbodyHead` hook
...
Using `.innerHTML` to create a `<script>` element does create a DOM
node, but the script is not actually executed. Fortunately, creating a
DocumentFragment does cause the script to execute.
2021-06-18 17:50:15 -04:00
251cc7ab32
CSS: Fix button icon centering
2021-06-16 18:27:52 -04:00
cccabf45b8
pad: Move error message to the top of the gritter box
2021-06-06 21:31:49 -04:00
b2e94685fb
pad: Display error name in the gritter box
2021-06-06 21:31:40 -04:00
3c087af038
caretPosition: fix loading when iframe is hidden
2021-05-04 23:56:13 +02:00
c00031a8d8
skiplist: Use `Map.size` to get number of nodes
2021-05-03 01:42:03 -04:00
1cdfe9193b
skiplist: Convert `_keyToNodeMap` to a `Map` object
2021-05-03 01:42:03 -04:00
e2eb7327c2
skiplist: Sanity check inserted entries
2021-05-03 01:42:03 -04:00
9e2ef6ad5b
skiplist: Move `propagateWidthChange()` to `Node` class
2021-05-03 01:42:03 -04:00
fc103e7f2a
skiplist: Define a new `Node` class
2021-05-03 01:42:03 -04:00
9fc88f3601
skiplist: Convert point operations into `Point` methods
2021-05-03 01:42:03 -04:00
3c1be95e07
skiplist: Move point creation to a new `Point` class
2021-05-03 01:42:03 -04:00
8ae40e80f9
skiplist: Save entry in `_insertKeyAtPoint()`
2021-05-03 01:42:03 -04:00
0e424fa8c3
skiplist: Remove unnecessary `newKey` arg from `_insertKeyAtPoint()`
2021-05-03 01:42:03 -04:00
ab8c354f18
skiplist: Use ES6 class syntax
...
This makess it easier to examine state in dev console.
2021-05-03 01:42:03 -04:00
303fd297bd
editor: Improve documentation comments
2021-05-03 01:42:03 -04:00
cbbcef8e90
AttributeManager: Add sanity checks
2021-05-03 01:42:03 -04:00
d40d59d9eb
AttributeManager: Simplify logic
2021-05-03 01:42:03 -04:00
e3d32a26b6
skiplist: Delete unused methods
2021-05-03 01:42:03 -04:00
f650c3d73e
editor: Delete unused `PROFILER` code
2021-05-03 01:42:03 -04:00
ab4e99f67a
editor: Delete commented-out code
2021-05-03 01:42:03 -04:00
d01b593d3c
chat: Ensure that `ctx.text` is interpreted as HTML
2021-04-11 06:20:29 +02:00
a3a0ff7bc1
chat: Use jQuery to build the chat message DOM object
...
This reduces the likelihood of accidentally introducing an XSS
vulnerability.
2021-04-11 06:20:29 +02:00
74554d36a5
chat: Allow `chatNewMessage` hook to modify more values
2021-04-11 06:20:29 +02:00
91e99c84ca
import: Reduce log spam from unsupported elements
2021-04-09 18:43:02 +02:00
09c349e2a1
import: Use a Set for supported elements
2021-04-09 18:43:02 +02:00
a796811558
escape userId before setting it as HTML attribute
2021-04-07 23:29:27 -04:00
7cbb3f565d
tests: Speed up `helper.edit()` and `helper.clearPad()`
2021-04-02 15:46:27 +02:00
2776946627
tests: Use cookie libraries to manipulate cookies
2021-04-01 14:31:56 +02:00
202d65d2bb
pad_cookie: Re-read prefs cookie on every call to `getPref()`
...
This makes it easier to write tests that clear the prefs cookie.
2021-04-01 14:31:56 +02:00
0df41a9a78
pad_cookie: Move initial cookie read+save to `init()`
...
Benefits of this change:
* It avoids race conditions with tests that clear cookies.
* Any attempt to get or set a value before `init()` is called will
throw an error, ensuring the API is used properly.
* Improved readability: It's easier to understand what the
`pad.noCookie` check is doing.
2021-04-01 14:31:56 +02:00
1fdaf95c3b
collab_client: Delete unused `NO_COMMIT_PENDING` handling
2021-03-30 16:42:53 -04:00
63a1f078f4
collab_client: Redo server message queueing
...
Move server message queue processing out of `handleUserChanges()` for
the following reasons:
* Fix a race condition: Before this change the client would stop
processing incoming messages and stop sending changes to the
server if a `NEW_CHANGES` message arrived while the user was
composing a character and waiting for an `ACCEPT_COMMIT` message.
* Improve readability: The `handleUserChanges()` function is for
handling changes from the local user, not for handling changes
from other users.
* Simplify the code.
2021-03-30 16:42:53 -04:00
e99fe88537
collab_client: Use `Date.now()` instead of casting a Date object
...
Also rename the `t` variable to `now` to improve readability.
2021-03-30 16:42:53 -04:00
5c445eac21
collab_client: Convert `state` var to `committing` bool
2021-03-30 16:42:53 -04:00
3ee6b5eb2b
collab_client: Delete unused `caughtErrors`
2021-03-30 16:42:53 -04:00
81b9a2544d
collab_client: Factor out duplicate `ACCEPT_COMMIT` code
2021-03-30 16:42:53 -04:00
b9753dcc71
Changeset: Return a new op object by default when iterating
...
Reusing the same op object for each iteration can result in very weird
behaviors because previously yielded op objects will get a surprise
mutation.
It is unclear why the code was written to reuse the same object. There
was no comment, nor is there a commit message providing rationale (it
has behaved this way since the very first commit). Perhaps the objects
were reused to improve performance (fewer object allocations that need
to be garbage collected). I do expect this change to reduce
performance somewhat, but not enough to warrant reverting this commit.
2021-03-29 18:42:55 -04:00
2b98b930d7
scaling: include padId in socketio query string
2021-03-24 16:07:11 +00:00
c208d50c4a
add version string to iframe_editor.css
2021-03-20 16:42:08 +00:00
3ad1d0a74f
cssmanager: Refactor CSS manager creation to avoid race condition
...
Safari takes a while to initialize `document.styleSheets`, which
results in a race condition when loading the pad. Avoid the race
condition by accessing the CSSStyleSheet objects directly from the
HTMLStyleElement DOM objects.
2021-03-20 01:07:16 +00:00
e2bfe2fd10
pad_editor: Promisify `init()`
2021-03-20 01:07:16 +00:00
81e36cf3c7
Ace2Inner: Promisify `init()`
2021-03-20 01:07:16 +00:00
742a7cd430
cssmanager: Throw if no matching style sheet is found
...
This avoids a later null dereference when the stack trace isn't as
useful.
2021-03-20 01:07:16 +00:00
5b05ee79ff
cssmanager: Simplify iteration over style sheets
2021-03-20 01:07:16 +00:00
cb9f6d6776
ace: Use iframe `srcdoc` property to refine frame load logic
...
This seems to fix "null is not an object (evaluating
'browserSheet.insertRule')" errors on Safari.
2021-03-19 17:06:58 +01:00
6f591b5c77
add class pad to timeslider to fix height issue ( #4941 )
2021-03-12 21:16:22 -05:00
8e2a21ec84
arrow functions dont have arguments ( #4943 )
2021-03-12 14:25:14 -05:00
926f0fcefb
CSS: Increase size of contenteditable area
2021-03-08 14:39:18 +00:00
404486069c
ace: Build the outer and inner iframes programmatically
...
This makes the code easier to read and it silences Chrome's
`document.write()` warning:
https://developers.google.com/web/updates/2016/08/removing-document-write
This is a redo of commit a17f9bf3cf912f0f195f
2021-03-05 19:31:59 +00:00
60da2373a6
CSS: Add comment to `no-skin/pad.css` to silence warning
...
Firefox prints "Style sheet could not be loaded" if the file is empty.
2021-03-05 07:45:48 +00:00
5546cc5e7b
CSS: Delete bogus `<link>` tag
...
Browsers report an error with this tag. Strangely, this tag has
existed since Etherpad's very first commit.
2021-03-05 07:45:48 +00:00
470f40d7db
CSS: Use `auto` for iframe body height
...
This change makes no visual difference right now, but will matter (for
reasons I don't understand) once we change `ace.js` to build the
iframes by constructing elements in JavaScript (vs. writing HTML).
2021-03-05 07:45:48 +00:00
48e1d1c23f
CSS: Fix class name for outer iframe `<html>` tag
...
* Add the class "pad" to the `<html>` tag in `pad.html` (the outer
iframe's parent).
* Change the CSS selector that refers to the `<html>` tag in
`pad.html` from `html:not(.inner-editor)` to `html.pad`.
* Change the class name of the outer iframe's `<html>` tag from
"inner-editor" to "outer-editor".
* Update CSS rules to use the new class name.
2021-03-05 07:45:48 +00:00
912f0f195f
Revert "ace: Build the outer and inner iframes programmatically"
...
This reverts commit a17f9bf3cf
2021-03-04 02:05:54 +00:00
0aad3b74da
pluginfw: Improve rendering of hook list
...
There are two main benefits:
* HTML is no longer printed in the startup debug logs.
* `require()` is no longer called on client-side files. This
eliminates "Failed to load <file> for <plugin>: ReferenceError:
window is not defined" errors when users visit
`/admin/plugins/info`.
2021-03-03 11:19:37 +00:00
7e698baa80
pluginfw: Improve hook function load error message
2021-03-03 11:19:37 +00:00
f95b09e0b6
Import: Import don't show warnings for supported elements
2021-03-02 17:14:47 +00:00
b0862cd030
ace: Delete all `$$INCLUDE_CSS` logic
...
The intention of the deleted code was to reduce the number of fetches,
but it only saved a single fetch due to implementation flaws. The
right way to reduce the number of fetches is to use a bundling
technology such as webpack, and this change makes it easier to do so.
2021-03-01 14:32:33 +00:00
66d3ac3783
ace: Debug logging
2021-03-01 14:32:33 +00:00
a17f9bf3cf
ace: Build the outer and inner iframes programmatically
...
This makes the code easier to read and it silences Chrome's
`document.write()` warning:
https://developers.google.com/web/updates/2016/08/removing-document-write
2021-03-01 14:32:33 +00:00
c696732838
ace: Asyncify `Ace2Editor.init()`
2021-03-01 14:32:33 +00:00
159fd5bdeb
ace: Simplify passing of `editorInfo`
2021-03-01 14:32:33 +00:00
e57829183d
ace: Pass objects to Ace2Inner via function args
2021-03-01 14:32:33 +00:00
6fe0154129
ace: Use absolute URLs when building iframes
...
This isn't strictly necessary right now, but will become
necessary (due to a Safari quirk) when we change to building the
iframes programmatically (vs. the current `document.write()`
approach).
2021-03-01 14:32:33 +00:00
9cfc2fb801
ace: Simplify the `aceEditorCSS` hook map function
2021-03-01 14:32:33 +00:00
Richard Hansen
webzwo0i
John McLear
Volker Bijewitz
Xavier Mehrenberger