Richard Hansen
9ffb2ccfb0
Revert "scripts: Various shell script cleanups ( #4008 )"
...
This reverts commit fba4fd5314#4008 were squashed into a single
commit and rebased. Somewhere along the way a mistake was made in a
merge conflict resolution, resulting in some bad code in
`bin/buildForWindows.sh`. This commit reverts the bad squashed commit.
2020-06-03 23:11:44 -04:00
Richard Hansen
fba4fd5314
scripts: Various shell script cleanups ( #4008 )
2020-06-01 21:02:44 +01:00
muxator
a181ea8fbe
bin: replace double backticks (``) with $()
...
This has been the recommended way of launching subshells for ages, and is easier
to type and on the eye.
For a quick reference, see:
https://unix.stackexchange.com/questions/5778/whats-the-difference-between-stuff-and-stuff#5782
2020-03-29 00:53:17 +01:00
muxator
0a86024797
startup scripts: get rid of $* and replace it with properly quoted "$@"
...
In shell scripts an unquoted $* is rarely useful, for example because it breaks
in presence of file names with spaces.
References:
- https://google.github.io/styleguide/shell.xml
Use "$@" unless you have a specific reason to use $*.
- https://unix.stackexchange.com/questions/41571/what-is-the-difference-between-and#94200
Short answer: use "$@" (note the double quotes). The other forms are very
rarely useful.
2019-12-01 01:52:32 +01:00
Luiza Pagliari
59cae81152
[chore] Allow debug mode on node versions >= 6.3 ( #3527 )
...
I've tried to install `node-inspector` using Node 8 and it looks like it is not supported.
According to the [documentation of that tool](https://www.npmjs.com/package/node-inspector ):
> Since version 6.3, Node.js provides a built-in DevTools-based debugger which mostly deprecates Node Inspector (...). The built-in debugger (...) provides certain advanced features (...) that are too difficult to implement in Node Inspector.
As [we require nodejs >= 6.9.0](https://github.com/ether/etherpad-lite#requirements ), and as [`node-inspector` only works on Chrome and Opera](https://www.npmjs.com/package/node-inspector#debug ), it looks like a good approach to remove the dependency of that tool and use Chrome DevTools directly. Besides, [there are other tools available](https://nodejs.org/en/docs/guides/debugging-getting-started/#inspector-clients ) for debugging, if Chrome is not an option.
This PR also allow external connections to the inspector, so Etherpad instances running on containers can also be debugged. [There are obviously some risks to leave that opened on public IPs](https://nodejs.org/en/docs/guides/debugging-getting-started/#exposing-the-debug-port-publicly-is-unsafe ), but I assumed no instance would run on debug mode for the final user.
2018-12-22 10:28:50 -02:00
HairyFotr
c7548450c0
Typos and minor fixes in bin, doc, and root
2017-09-14 13:33:27 +02:00
Peter 'Pita' Martischka
0e110efe9e
fix debugRun
2012-03-04 21:06:37 +01:00
Egil Moeller
da52353ba3
The big rename of pluginbs from pluginomatic to ep
2012-02-26 13:54:32 +01:00
Egil Moeller
1239ce7f28
The Big Renaming - etherpad is now an NPM module
2012-02-26 13:07:51 +01:00
Garrett LeSage
d0addfddb3
spelling fixes in the shell scripts
2011-08-03 23:18:12 +02:00
Garrett LeSage
c984f496c2
fixed issue # 64, making the shell scripts more portable (for OS X)
2011-08-03 23:08:27 +02:00
Peter 'Pita' Martischka
de5c0741f7
improved the bin files
2011-07-27 14:37:12 +01:00
Peter 'Pita' Martischka
6b43d2252b
fixed merge conflicts
2011-07-26 19:30:39 +01:00
Peter 'Pita' Martischka
2e163f2924
reorganzied the bin folder
2011-07-26 17:00:56 +01:00
