etherpad-lite/.github/workflows
John McLear 9b03f8f6ab
tests: fix importexport frontend tests (#4827)
* CI: Leave log level at INFO for frontend tests

* CI: Disable frontend admin tests for non-admin workflow

* CI: Disable import/export rate limiting for frontend tests

* tests: fix importexport tests

The testing approach was redone to fix numerous issues:
  * Even if the tests had been working, none of them would have caught
    https://github.com/ether/etherpad-lite/issues/4808 because they
    didn't exercise the client-side import logic. Now they do.
  * Follow-up logic was not in the `helper.waitFor()` callback like it
    should have been. Now the code uses `async` and `await` to ensure
    proper execution order.
  * All `$.ajax()` calls used `async: false`. Now they're properly
    asynchronous.
  * The `helper.waitFor()` condition callbacks threw instead of
    returning false.
  * The string comparisons didn't allow for different attribute
    order (e.g., `<ol start="1" class="list-number1">` vs. `<ol
    class="list-number1" start="1">`). Now `Node.isEqualNode()` is
    used to reduce fragility. (`Node.isEqualNode()` is not perfect, so
    the tests are still a bit fragile: If class names or style strings
    are in a different order then `Node.isEqualNode()` will return
    false even if the nodes are semantically equivalent.)

Co-authored-by: Richard Hansen <rhansen@rhansen.org>

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-02-22 10:40:38 +00:00
..
backend-tests.yml tests: try all supported node versions 2021-02-22 03:36:12 -05:00
codeql-analysis.yml Create codeql-analysis.yml 2020-08-24 17:57:30 +01:00
dockerfile.yml restructure: Prefix bin/ and tests/ with src/ 2021-02-05 21:52:08 +00:00
frontend-admin-tests.yml tests: fix importexport frontend tests (#4827) 2021-02-22 10:40:38 +00:00
frontend-tests.yml tests: fix importexport frontend tests (#4827) 2021-02-22 10:40:38 +00:00
lint-package-lock.yml GitHub workflows: Install Node.js v12 2021-02-09 22:18:35 +00:00
load-test.yml tests: Pass --legacy-peer-deps flag to work around npm v7 bug 2021-02-22 03:36:12 -05:00
rate-limit.yml GitHub workflows: Install Node.js v12 2021-02-09 22:18:35 +00:00
windows-zip.yml CI: Build and test Windows .zip (#4828) 2021-02-20 04:13:44 -05:00