6198e92706
tests: Pass `--legacy-peer-deps` flag to work around npm v7 bug
...
This flag is unknown to npm v6, but npm v6 silently ignores unknown
flags.
2021-02-22 03:36:12 -05:00
588b73f366
tests: Install deps after installing plugins
2021-02-22 03:36:12 -05:00
5ea66701f7
tests: Use `--no-save` when installing plugins on Windows
2021-02-22 03:36:12 -05:00
14a9749b75
tests: add assert helper for supporting node 10.x
2021-02-22 03:36:12 -05:00
ce83181ac3
Lgtm bugfixes ( #4838 )
...
* code tidy up: always evaluates
* tidy up: is always true
* tidy up: remove unused code
* always true/false variables
* unused variable
* tidy up: remove unused code in caretPosition.js
* for squash: Revert "tidy up: remove unused code in caretPosition.js"
The `if` condition was previously always true, so the body should be
preserved. If the body is preserved, other logic can be deleted. I
opened PR #4845 to clean it all up.
This reverts commit 75b03e5a7dc1ff9a8728ed2341fd9fe970d0615f.
* for squash: simplify
* for squash: Explain that the getter is used for its side effects
It's very weird to call a getter without using its return value. Add a
comment explaining why this is done so that the reader doesn't get
confused.
* for squash: Revert "tidy up: remove unused code"
The exception test was the purpose of the code.
This reverts commit 85153b167613b2513fff99e22b8ded8ea1e4547b.
* for squash: Log the tsort results
Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-02-22 08:26:35 +00:00
de186fbe36
Update node in docker to version 14 ( #4844 )
2021-02-22 01:34:34 -05:00
40d7480d5b
lint: padaccess.js
2021-02-21 21:09:02 -05:00
029729a386
lint: Settings.js
2021-02-21 21:09:02 -05:00
435562299f
lint: NodeVersion.js
2021-02-21 21:09:02 -05:00
7352dc7571
lint: ImportEtherpad.js
2021-02-21 21:09:02 -05:00
613c7d8545
lint: ExportTxt.js
2021-02-21 21:09:02 -05:00
d2359be08b
lint: ExportHtml.js
2021-02-21 21:09:02 -05:00
5718c8b360
lint: AbsolutePaths.js
2021-02-21 21:09:02 -05:00
b1614f0592
lint: i18n.js
...
Partial, still 3 more to do that are slightly higher hanging that can get done.
2021-02-21 21:09:02 -05:00
586af5e16e
lint: padurlsanitize.js
2021-02-21 21:06:38 -05:00
86c938cae2
lint: openapi.js
2021-02-21 21:06:38 -05:00
25d4faddd9
lint: SocketIORouter.js
2021-02-21 21:06:38 -05:00
5201cb717f
lint: PadMessageHandler.js
2021-02-21 21:06:38 -05:00
d67f170c46
lint: eejs/index.js
2021-02-21 21:06:38 -05:00
3ed4ac649c
lint: PadManager.js
2021-02-21 21:02:59 -05:00
6b6201b448
null link on plugins and noopener / noreferrer
...
Resolves a (non) security issue brought up by LGTM but I think the noopener and norefferer are good shouts
2021-02-21 19:30:39 +00:00
2c763fb4d1
Delete dirty-db-cleaner.py
2021-02-21 18:07:20 +00:00
543e94fd4a
timeslider: slight improvement on code quality ( #4836 )
...
This is an interim patch, ultimately the JS needs to be thrown out of the HTML...
2021-02-21 17:59:15 +00:00
1b8cd0747d
Move vendor libraries to /vendors folder and exclude from LGTM
2021-02-21 15:07:39 +00:00
0bb3e65020
fix for caching plugin-definitions
2021-02-21 14:31:15 +00:00
bdb78adb3f
Update CHANGELOG.md
2021-02-21 13:50:55 +00:00
086b59b30d
editor: UI polish - Etherpad brand as reconnect & loading animation
2021-02-21 13:24:51 +00:00
6023117d29
CI: Use `saucelabs/sauce-connect-action` to create the tunnel ( #4833 )
2021-02-21 13:17:41 +00:00
bb14775820
drop apiRoot object from build
2021-02-21 11:08:07 +00:00
227370547d
update openapi-backend
2021-02-21 11:08:07 +00:00
ee2b32281c
pluginfw: Warn plugins on missing plugin ( #4826 )
...
* pluginfw: Warn plugins on missing plugin
Add functionality to console.warn when a plugin is missing. This will help admins know when people are trying to use plugins that are missing. Resolves https://github.com/ether/etherpad-lite/issues/4730
* pluginfw: importing .etherpad can notify admins of missing plugins
Extending .etherpad imports to notify admins if a missing plugin is present
* Update ImportEtherpad.js
2021-02-21 11:07:13 +00:00
77b2f372ab
lint: pad_userlist.js arrow functions
...
This probably needs a good rewrite/refactor to remove self.
2021-02-21 11:05:25 +00:00
2511eed472
lint: Changeset.js more literal conditionals
2021-02-21 11:05:25 +00:00
8cbd5222dd
lint: pad_userlist.js - remove require browser
2021-02-21 11:05:25 +00:00
73b3a2dc54
lint: AttributeManager.js use ES6 method for hasAttrib
2021-02-21 11:05:25 +00:00
f86578ffc3
lint: changesettracker.js var > const/let and other easy fixes
2021-02-21 11:05:25 +00:00
3635cb6ca6
lint: changesettracker.js long-lines
2021-02-21 11:05:25 +00:00
f5f4e3a6d1
lint: changesettracker.js arrow funcs
2021-02-21 11:05:25 +00:00
d4b6cbc897
line: broadcast.js
2021-02-21 11:05:25 +00:00
3b5b996d84
lint: Changeset no var
2021-02-21 11:05:25 +00:00
0b78ad2f90
lint: Changeset.js curly braces in correct position
2021-02-21 11:05:25 +00:00
23d7544763
lint: Changeset.js max-len
2021-02-21 11:05:25 +00:00
98a0e76a20
lint: Changeset.js opcode eqeqeq checks
2021-02-21 11:05:25 +00:00
d91f2b5b07
lint: Changeset.js additional arrow functions
2021-02-21 11:05:25 +00:00
acccf56724
lint: Changeset.js arrow-functions
2021-02-21 11:05:25 +00:00
cf37f52093
lint: collab_client.js
2021-02-21 11:05:25 +00:00
b029edb931
lint: index.js
2021-02-21 11:05:25 +00:00
01dd004054
lint: ChangesetUtils
2021-02-21 11:05:25 +00:00
7c51446040
lint: use strict
2021-02-21 11:05:25 +00:00
c64b1b8ead
lint: skins
2021-02-21 11:05:25 +00:00
Richard Hansen
webzwo0i
John McLear
Stefan