50b9e0df1f
PadMessageHandler: Use values from session info object
...
This is more consistent with the rest of the code, and it provides a
single source of truth.
2021-10-30 03:07:40 -04:00
10e930408c
PadMessageHandler: Delete unnecessary CLIENT_READY checks
...
The checks are already performed by the security manager.
2021-10-30 03:06:57 -04:00
0992f19570
PadMessageHandler: Improve readability of historical author fetch
2021-10-30 03:06:57 -04:00
d36a37d666
PadMessageHandler: Delete unnecessary `protocolVersion`
...
We can assume that the client code is always in sync with what the
server expects.
2021-10-30 03:06:57 -04:00
ce730b0493
PadMessageHandler: Inline `createSessionInfoAuth()`
...
This function is only used once so it doesn't need to be separate.
2021-10-30 03:06:57 -04:00
fa54dc1053
PadMessageHandler: Run the `clientReady` hook asynchronously
2021-10-30 03:06:57 -04:00
5d30e0b1b2
PadMessageHandler: Run the `userLeave` hook asynchronously
2021-10-30 03:06:57 -04:00
f2a118b311
PadMessageHandler: Inline unnecessary variables
...
Also delete some unneccessary comments.
2021-10-30 03:06:15 -04:00
7522d76c40
PadMessageHandler: Invert condition to improve readability
2021-10-30 03:03:19 -04:00
a3b4d985ac
lint: Fix awkward string formatting
2021-10-30 03:03:19 -04:00
80e84636d7
pad: Promisify `handshake()`
2021-10-29 19:38:28 -04:00
cd4f5ff281
pad: Defer message handling until handshake completes
2021-10-29 19:37:28 -04:00
be0298290d
pad: Move post-handshake code to `_afterHandshake()`
2021-10-29 19:27:33 -04:00
9fb754ce3a
pad: Initialize pad cookie before starting the handshake
2021-10-29 19:27:33 -04:00
f6c5ce606e
pad: Move UI setup from `handshake()` to `init()`
2021-10-29 19:27:33 -04:00
bd44a87388
pad: Unexport unnecessarily exported `handshake()` function
2021-10-29 19:27:33 -04:00
5cbbcbcee6
pad: Simplify reload after `.etherpad` import
...
The old "switch to pad" logic looked buggy, and it complicates pad
initialization. Forcing a refresh after importing an `.etherpad` file
isn't much of a UX downgrade.
2021-10-29 19:27:33 -04:00
e974622561
pad: Use `window.` to avoid ESLint error
2021-10-29 19:27:33 -04:00
d8ca3a693d
timeslider scrollTo: fixes wrong line number calculation in case there
...
are no attribute changes and no length changes
2021-10-29 02:38:29 -04:00
9bad1d03d3
importHtml: do not add an useless identity changeset
2021-10-29 02:29:45 -04:00
f7f5e3dad8
setText: prevent adding useless revision in case the pad text did not
...
change
2021-10-29 02:29:45 -04:00
63de249236
tests: do not re-add identical text with setText
2021-10-29 02:29:45 -04:00
668d62fa3f
importHtml: avoid race when applying empty document and the import changeset at the same time
2021-10-29 02:29:45 -04:00
8eb5640cb7
fix: upgrade express-rate-limit from 5.4.0 to 5.4.1
...
Snyk has created this PR to upgrade express-rate-limit from 5.4.0 to 5.4.1.
See this package in npm:
https://www.npmjs.com/package/express-rate-limit
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-29 02:25:09 -04:00
dd8608fe6e
fix: upgrade rate-limiter-flexible from 2.3.0 to 2.3.1
...
Snyk has created this PR to upgrade rate-limiter-flexible from 2.3.0 to 2.3.1.
See this package in npm:
https://www.npmjs.com/package/rate-limiter-flexible
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-29 02:22:24 -04:00
cea7eb8ba6
fix: upgrade mime-types from 2.1.32 to 2.1.33
...
Snyk has created this PR to upgrade mime-types from 2.1.32 to 2.1.33.
See this package in npm:
https://www.npmjs.com/package/mime-types
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-26 10:12:27 +00:00
0d67d05b78
fix: upgrade express-rate-limit from 5.3.0 to 5.4.0
...
Snyk has created this PR to upgrade express-rate-limit from 5.3.0 to 5.4.0.
See this package in npm:
https://www.npmjs.com/package/express-rate-limit
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-25 19:10:13 -04:00
2c15ae6ac9
Localisation updates from https://translatewiki.net .
2021-10-25 13:04:22 +02:00
de3dfb5ce2
AttributePool: Add JSDoc comments
2021-10-24 21:18:56 -04:00
c98b521539
AttributePool: Use ES6 class syntax
2021-10-24 21:18:56 -04:00
bbc8b29ffd
Changeset: Improve JSDoc comments
...
Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-10-24 21:18:56 -04:00
2c15e68e4a
fix: upgrade clean-css from 5.2.0 to 5.2.1
...
Snyk has created this PR to upgrade clean-css from 5.2.0 to 5.2.1.
See this package in npm:
https://www.npmjs.com/package/clean-css
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-22 07:26:47 +00:00
41e2ee4848
fix: upgrade rate-limiter-flexible from 2.2.4 to 2.3.0
...
Snyk has created this PR to upgrade rate-limiter-flexible from 2.2.4 to 2.3.0.
See this package in npm:
https://www.npmjs.com/package/rate-limiter-flexible
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-20 08:24:39 +00:00
ccd7a8d5ff
fix: upgrade threads from 1.6.5 to 1.7.0
...
Snyk has created this PR to upgrade threads from 1.6.5 to 1.7.0.
See this package in npm:
https://www.npmjs.com/package/threads
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-17 02:32:13 -04:00
1a008ed6fa
fix: upgrade clean-css from 5.1.5 to 5.2.0
...
Snyk has created this PR to upgrade clean-css from 5.1.5 to 5.2.0.
See this package in npm:
https://www.npmjs.com/package/clean-css
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-17 06:17:34 +00:00
4f283b64cf
tests: easysync: Inline some functions that are only used once
2021-10-17 00:49:34 +02:00
e535129f3c
tests: easysync: Use `expect.js` for checks
2021-10-17 00:49:34 +02:00
ebb7dfabd7
tests: easysync: Use mocha `describe()` and `it()`
2021-10-17 00:49:34 +02:00
2c7d0604c3
tests: easysync: Remove unnecessary `Random` class
2021-10-17 00:49:34 +02:00
8dd61f847e
tests: easysync: Fix some ESLint errors
2021-10-17 00:49:34 +02:00
59a6a9f6a0
tests: easysync: Delete commented-out and unused code
2021-10-17 00:49:34 +02:00
428736cdc3
tests: easysync: Run with the frontend tests
2021-10-17 00:49:34 +02:00
3722d943c7
fix: upgrade terser from 5.8.0 to 5.9.0
...
Snyk has created this PR to upgrade terser from 5.8.0 to 5.9.0.
See this package in npm:
https://www.npmjs.com/package/terser
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-13 07:15:16 +00:00
0ea6f1518c
tests: Remove overly agressive timeouts
2021-10-07 20:31:54 -04:00
3a5c44c8f7
/jserror: Enable colors to improve readability
2021-10-07 19:55:02 -04:00
629e7d5072
/jserror: Log all of the provided data
2021-10-07 19:55:01 -04:00
cb01ae8cbb
/jserror: Reject files
2021-10-07 19:55:01 -04:00
e909072776
/jserror: Refactor to handle errors better
2021-10-07 19:55:01 -04:00
788eb86d84
Ace2Inner: Inline code that is unnecessarily inside an IIFE
2021-10-07 19:53:40 -04:00
4890cd8972
Ace2Inner: Delete completed TODO comment
2021-10-07 19:53:40 -04:00
a7c78768a1
ExportHelper: Simplify `_analyzeLine()` a bit
2021-10-07 19:53:40 -04:00
d8cbd134d3
PadMessageHandler: Improve readability
2021-10-07 19:53:40 -04:00
019e296c4a
lint: Fix awkward string formatting
2021-10-07 19:53:40 -04:00
044f6543a5
lint: Fix ESLint errors (mostly camelcase warnings)
2021-10-07 19:53:40 -04:00
34cfff4e4c
Changeset: Delete unused code
2021-10-07 19:53:40 -04:00
eb495e9ea2
Changeset: Move out obsolete code
2021-10-07 19:53:40 -04:00
2155e216a6
tests: Remove overly agressive timeouts
2021-10-07 19:53:03 -04:00
ac3a7191cf
Localisation updates from https://translatewiki.net .
2021-10-07 13:03:04 +02:00
a7734ddd94
deps: Update ueberdb2 to 1.4.18
...
This pulls in newer versions of some database drivers which silences
some `npm audit` security warnings.
This also adds support for PostgreSQL connection strings.
2021-10-07 03:58:35 -04:00
ee610027c0
fix: upgrade terser from 5.7.2 to 5.8.0
...
Snyk has created this PR to upgrade terser from 5.7.2 to 5.8.0.
See this package in npm:
https://www.npmjs.com/package/terser
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-10-05 06:23:36 +00:00
e8514db365
tests: Replace manual checks with `assert`
2021-10-03 20:23:30 -04:00
72b12bc97b
tests: Slight backend test reorganization
...
* Delete some useless uses of `describe()`
* Combine some dependent tests
* Rename some tests to avoid duplicate names
2021-10-03 20:06:33 -04:00
dd37251da4
tests: Promisify some backend tests
2021-10-03 19:25:50 -04:00
39a971e3b9
tests: Remove overly aggressive timeouts
2021-10-03 19:25:50 -04:00
c361df52d2
bugfix: Allow selection to start/end before line marker
2021-10-02 02:41:58 -04:00
37a33042d2
ace2_inner: Improve rep documentation
2021-10-02 02:10:07 -04:00
e42e5457c1
LibreOffice: Improve logging
2021-10-01 03:01:24 -04:00
76374bc489
LibreOffice: Close stdin right away
...
This should prevent LibreOffice from hanging if it attempts to read
from stdin (it'll get EOF and probably exit with an error instead).
2021-10-01 03:01:24 -04:00
0c31940b09
Localisation updates from https://translatewiki.net .
2021-09-30 13:02:24 +02:00
4d8ae3475d
Changeset: Add documentation for `textLinesMutator()`
2021-09-30 12:29:24 +02:00
0de41ee087
adminsettings test: Fix save detection race condition
...
Use MutationObserver to detect if a saveProgress event was received,
which will trigger an animation.
Before this, `helper.admin$('#response').is(':visible')` was true
after the page loaded and before clicking the Save button, so there
was a possibility that after clicking Save, but before sending the
socketio message to the server, the visibility is checked and returns
true, so the page gets reloaded before the changed settings have been
saved.
2021-09-29 23:49:16 -04:00
bb0ca91dc2
adminupdateplugins test: swap assertions, increase timeout
2021-09-29 23:49:16 -04:00
91d3974a0d
adminsettings test: Be a little stricter for some assertions
2021-09-29 23:46:25 -04:00
cc6fda6916
adminsettings test: Fix restart detection
...
We cannot guarantee that the system time on SauceLabs and Github is in
sync. In case the SauceLabs runner's clock is slow the test would have
failed.
2021-09-29 23:42:41 -04:00
0e311184cf
fix: change directory to etherpad root
2021-09-28 19:01:19 -04:00
aec619cc0b
log4js: Deprecate the `logconfig` setting
...
This will make it possible to upgrade log4js in a future version.
2021-09-28 04:30:26 -04:00
b3b6c94b76
log4js: Initialize as early as possible
2021-09-28 04:30:26 -04:00
7653dc650d
settings: Use a log4js logger instead of `console`
2021-09-28 04:30:26 -04:00
653dbb3449
tests: Wait for pad init before returning from `helper.aNewPad()`
...
This should make it easier to avoid race conditions.
2021-09-28 04:18:24 -04:00
4d2839457a
CSS: Fix underscore and clear authorship icon alignment
2021-09-26 12:07:56 +02:00
4637b2b729
fix: upgrade js-cookie from 3.0.0 to 3.0.1
...
Snyk has created this PR to upgrade js-cookie from 3.0.0 to 3.0.1.
See this package in npm:
https://www.npmjs.com/package/js-cookie
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=referral&page=upgrade-pr
2021-09-23 08:10:28 +00:00
15f17b5237
tests: Avoid deprecated `Builder.withCapabilities()` method
2021-09-15 19:42:11 -04:00
73cb698ba0
tests: Update selenium-webdriver to 4.0.0-rc-1
2021-09-15 19:40:47 -04:00
70c16bb1b5
tests: Check import of export of read-only pad ID
2021-09-15 18:32:06 -04:00
b683dc300d
tests: Check for leak of read-write pad ID when exporting
2021-09-15 18:32:06 -04:00
0f5a4bd1f8
tests: Restructure read-only pad export tests
...
This also adds coverage for `.etherpad` exports.
2021-09-15 18:32:06 -04:00
dbd76f0c5d
export: Don't leak writeable pad ID when exporting
...
Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-09-15 18:32:06 -04:00
58bd96ce8f
padreadonly: Remove dead `/ro/:id` handling
...
Read-only pads are accessed using `/p/` path since commit
ba3430ebb7
2021-09-14 17:07:55 -04:00
d58b649c76
Localisation updates from https://translatewiki.net .
2021-09-09 13:02:49 +02:00
03275ba227
deps: Regenerate `src/package-lock.json`
2021-09-06 14:47:11 -04:00
59ebaa78fd
deps: Update `src/package.json` versions to match lock file
2021-09-06 14:47:11 -04:00
ebe05f8e63
deps: Delete unused `async-stacktrace` dependency
2021-09-06 14:47:11 -04:00
bc9cdd6957
SocketIORouter: Add acknowledgement support
2021-09-06 14:45:26 -04:00
9f9adb369b
SocketIORouter: Don't crash if message handler throws
2021-09-06 14:45:26 -04:00
320e5c1109
SocketIORouter: Add unit tests
2021-09-06 14:45:26 -04:00
94f71bd5e9
SocketIORouter: Add ability to unregister handler
...
This will make it easier to add tests.
2021-09-06 14:45:26 -04:00
2e93fca699
SocketIORouter: Logging improvements
2021-09-06 14:45:26 -04:00
b9609a749d
SocketIORouter: Rename variables to improve readability
2021-09-06 14:45:26 -04:00
4a09000ca6
installDeps.sh: Don't nuke `src/node_modules` on error
...
Rationale:
* Clearing out `src/node_modules` is unlikely to bring future
success.
* If there is an error, it's better to leave the filesystem alone so
that the user can investigate the cause.
* Deleting the directory on error is a surprising behavior.
2021-09-05 19:42:29 -04:00
2ba85dba0e
installDeps.sh: Handle errors
2021-09-05 19:36:05 -04:00
258b8366e2
installDeps.sh: Ensure that `ep_etherpad-lite` is a directory
2021-09-05 19:31:06 -04:00
cf7cf8be69
installDeps.sh: Quote underquoted expansions
2021-09-05 19:28:58 -04:00
8b89cb3f6f
installDeps.sh: Wrap long lines
2021-09-05 19:24:17 -04:00
42e59ff2cd
installDeps.sh: Simplify log message
2021-09-05 19:23:01 -04:00
348bc0c269
tests: Delete overly aggressive timeouts
...
See https://github.com/ether/etherpad-lite/issues/4988 for rationale.
2021-08-30 02:02:37 -04:00
67dfb64095
deps: Bump ueberdb2 to 1.4.15
2021-08-30 01:49:02 -04:00
942b686f2d
deps: Bump npm to 6.14.15
2021-08-30 01:22:44 -04:00
1e20936b5b
deps: Bump terser to 5.7.2
2021-08-29 23:37:06 -04:00
f5657510be
deps: Bump supertest to 6.1.6
2021-08-29 23:37:06 -04:00
327989ef0b
deps: Bump superagent to 6.1.0
2021-08-29 23:37:06 -04:00
96e66aab17
deps: Bump sinon to 11.1.2
2021-08-29 23:37:06 -04:00
c33a2682f9
deps: Bump semver to 7.3.5
2021-08-29 23:37:06 -04:00
550c7365c2
deps: Bump openapi-backend to 4.2.0
2021-08-29 23:37:06 -04:00
529d2f6b7d
deps: Bump rehype to 10.0.0
2021-08-29 23:37:06 -04:00
0accdf0a07
deps: Bump mocha to 9.1.1
2021-08-29 23:37:06 -04:00
72b22f7c02
deps: Bump measured-core to 2.0.0
2021-08-29 23:37:06 -04:00
7db3e4273d
deps: Bump jsdom to 17.0.0
2021-08-29 23:37:06 -04:00
7dbd278d1d
deps: Bump js-cookie to 3.0.0
2021-08-29 23:36:48 -04:00
ea43c92fe9
deps: Bump etherpad-cli-client to 0.1.12
2021-08-29 20:02:54 -04:00
912e72a8ac
deps: Bump clean-css to 5.1.5
2021-08-29 19:33:03 -04:00
3225abc3c7
deps: Bump eslint to 7.32.0
2021-08-29 19:23:43 -04:00
cca3ba94f9
fix: upgrade async from 3.2.0 to 3.2.1
...
Snyk has created this PR to upgrade async from 3.2.0 to 3.2.1.
See this package in npm:
https://www.npmjs.com/package/async
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-08-27 07:05:25 +00:00
3c159ef75e
fix: upgrade wtfnode from 0.9.0 to 0.9.1
...
Snyk has created this PR to upgrade wtfnode from 0.9.0 to 0.9.1.
See this package in npm:
https://www.npmjs.com/package/wtfnode
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-08-25 20:34:55 -04:00
0d65dc8a44
pad: Add `clientVars` to `postAceInit` hook context
...
This allows plugins to avoid the `clientVars` global variable.
2021-08-25 14:59:17 -04:00
b683cdfe0f
Localisation updates from https://translatewiki.net .
2021-08-23 13:03:03 +02:00
f08a443497
fix: upgrade rate-limiter-flexible from 2.2.3 to 2.2.4
...
Snyk has created this PR to upgrade rate-limiter-flexible from 2.2.3 to 2.2.4.
See this package in npm:
https://www.npmjs.com/package/rate-limiter-flexible
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-08-19 20:46:38 -04:00
05182d1d30
fix: upgrade mime-types from 2.1.31 to 2.1.32
...
Snyk has created this PR to upgrade mime-types from 2.1.31 to 2.1.32.
See this package in npm:
https://www.npmjs.com/package/mime-types
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-08-19 07:35:17 +00:00
fed950e809
ace2_inner: Simplify handler for Ctrl-@ (show authors)
2021-08-16 00:34:30 -04:00
88057eade2
ace2_inner: Readability improvements
2021-08-16 00:34:30 -04:00
bc6428025a
ace2_inner: Use for..of iteration to improve readability
2021-08-16 00:34:30 -04:00
f06307cb4c
ace2_inner: Fix for..in iteration
...
See commit c38c34bef4
2021-08-16 00:34:30 -04:00
2d50a8aa95
ace2_inner: Fix efficiency of `rangeForLine()`
...
Returning `true` or `false` has no effect when iterating using
`Array.prototype.forEach`. This fixes a bug introduced in commit
b28bfe8e31
2021-08-16 00:34:30 -04:00
ca2e008e7b
ace2_inner: Move variable declarations to appropriate scope
2021-08-16 00:34:30 -04:00
bf10e70f2e
ace2_inner: Delete unnecessary `currentLine` variable
2021-08-16 00:34:30 -04:00
9fc613d362
ace2_inner: Delete unnecessary checks
2021-08-16 00:34:30 -04:00
a5f9c60a34
ace2_inner: Operate on Elements, not Nodes
2021-08-16 00:34:30 -04:00
aad75e4661
ace2_inner: Factor out duplicate line number div creation
2021-08-16 00:34:30 -04:00
3237f8d123
ace2_inner: Simplify iteration over line number divs
2021-08-16 00:34:30 -04:00
b238d9610a
ace2_inner: Factor out duplicate line height application
2021-08-16 00:34:30 -04:00
1b890e3d4d
ace2_inner: Replace `lineNumbersShown` with number of children
2021-08-16 00:34:30 -04:00
27363bf729
ace2_inner: Add line number divs directly, not via fragment
...
There's no layout thrashing so the fragment doesn't provide any
benefit.
2021-08-16 00:34:30 -04:00
e1a024847c
ace2_inner: Delete unnecessary `innerdocbody` variable
2021-08-16 00:34:30 -04:00
7d807d2fc5
ace2_inner: Delete unnecessary `container` variable
2021-08-16 00:34:30 -04:00
4b4584c264
ace2_inner: Delete unnecessary `doc` and `root` variables
2021-08-16 00:34:25 -04:00
ec63c15a40
ace2_inner: Simplify document body selection
2021-08-16 00:31:09 -04:00
11c86e677a
ace2_inner: Consistently use `outerWin` and `outerDoc`
2021-08-16 00:31:09 -04:00
98c1ba5808
ace2_inner: Use destructuring assignment to simplify
2021-08-16 00:31:09 -04:00
c7be4f9d2d
ace2_inner: Move `sidedivinner` creation to ace.js
2021-08-16 00:31:09 -04:00
15b1d4cb75
ace2_inner: Build `sidedivinner` programmatically
2021-08-16 00:31:09 -04:00
b80295c228
ace2_inner: Combine declaration and initialization
2021-08-16 00:31:09 -04:00
7a8edc816b
ace2_inner: Replace `initLineNumbers()` with an IIFE
2021-08-16 00:31:09 -04:00
b5bfff43cf
ace2_inner: Delete redundant class assignment
2021-08-16 00:31:08 -04:00
e581ee01f2
ace2_inner: Formatting improvements
2021-08-16 00:30:50 -04:00
0ca5a3459f
Timeslider: Install an error handler
2021-08-14 07:44:05 -04:00
1e22e0102d
Timeslider: Move `<title>` and `<script>` inside `<head>`
2021-08-14 07:44:05 -04:00
b6fba9d66d
Pad: Improve page load error handler
...
* Install the error handler early.
* Include stack trace.
* Remove unnecessary escaping.
* Improve formatting.
* Move to a separate script file.
2021-08-14 07:44:05 -04:00
d4e74fd038
Pad: Add missing `<head>` and `<body>` tags
...
The comment "head and body had been removed intentionally" implies
that the tags were causing some sort of problem, but the commit that
removed them (57075d1545
2021-08-14 07:44:05 -04:00
4a1f21ce34
pad_editbar: Convert snake case to camel case
2021-08-14 07:26:31 -04:00
5478d2ce60
pad_editbar: Use ES6 class syntax for readability
2021-08-14 07:26:31 -04:00
97ccf9e082
pad_editbar: Factor out duplicate code
2021-08-14 07:08:57 -04:00
ee41de4809
pad_editbar: Deprecate the `toggleDropDown` callback
2021-08-14 07:08:57 -04:00
c629ee09a8
pad_editbar: Call the callback asynchronously
...
This follows JavaScript best practices.
2021-08-14 07:08:57 -04:00
148e10821b
pad_editbar: Always call the callback
2021-08-14 07:08:57 -04:00
07e05a92eb
pad_editbar: Call the callback after all work is done
2021-08-14 07:08:57 -04:00
a1b924f746
pad_editbar: Don't pass a callback to `toggleDropDown()`
...
The function is synchronous so there's no point.
2021-08-14 07:08:57 -04:00
59d6a8b321
pad_editbar: Delete unnecessary `returned` variable
2021-08-14 07:01:50 -04:00
a4652d67a0
pad_editbar: Move `commands` up for readability
2021-08-14 07:01:50 -04:00
fda34407f9
pad_editbar: Move `dropdowns` initialization to constructor
...
This avoids null dereference if a buggy caller calls
`toggleDropDown('none')` before `init()`. (Ideally the caller would be
fixed, but this is not always feasible.)
2021-08-14 07:01:34 -04:00
42b0b1bf00
pad_editbar: Move `syncAnimation` out of `padeditbar` IIFE
...
This avoids the need for an IIFE.
2021-08-14 07:01:13 -04:00
ee996f530f
pad_editbar: Remove unnecessary `syncAnimationFn` variable
2021-08-14 07:01:13 -04:00
4b4eef5f4a
pad_editbar: Convert `registerDefaultCommands()` into a method
2021-08-14 07:01:13 -04:00
0d4f147349
pad_editbar: Simplify iteration
2021-08-14 07:01:13 -04:00
11faf6104a
pad_editbar: Convert `bodyKeyEvent()` into a method
2021-08-14 07:01:13 -04:00
b2fe6e3e7e
pad_editbar: Fix invalid use of `this`
2021-08-14 07:01:12 -04:00
b884628a5a
pad_editbar: Use arrow functions for callbacks, IIFEs
2021-08-14 07:01:12 -04:00
bdaa66c346
pad_editbar: Use `this` instead of `self`
2021-08-14 07:01:12 -04:00
118c66e5d0
HTML import: Improve log message for invalid HTML
2021-08-12 13:53:23 -04:00
c816c20bc7
HTML import: Replace cheerio with jsdom to simplify contentcollector
...
Cheerio provides jQuery-like objects but they wrap DOM Node-like
objects that are not 100% API compatible with the DOM spec. Because of
this, contentcollector, which is used in browsers and in Node.js
during HTML import, has until now needed to support two different
APIs. This commit modifies HTML import to use jsdom instead of cheerio
and simplifies contentcollector.
2021-08-12 13:53:23 -04:00
84d6d277d7
Accessibility fix for JAWS screen readers
...
ace.js: removed the role 'application' from innerDocument.body. JAWS
do not read any text from the edit lines if this role is set.
domline.createDomLine: to give JAWS the ability to read the lines
correctly, it is required to set the attribute 'aria-live' to
'assertive'.
2021-08-12 13:48:08 -04:00
15995acc2a
deps: Bump require-kernel and yajsml
...
This brings improvements to the readability of stack traces,
especially in Firefox.
2021-08-09 19:04:42 -04:00
9eadd9988f
Localisation updates from https://translatewiki.net .
2021-08-09 13:03:33 +02:00
33a43b7082
fix: upgrade rate-limiter-flexible from 2.2.2 to 2.2.3
...
Snyk has created this PR to upgrade rate-limiter-flexible from 2.2.2 to 2.2.3.
See this package in npm:
https://www.npmjs.com/package/rate-limiter-flexible
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-08-02 20:43:44 -04:00
fd4fb8874e
Localisation updates from https://translatewiki.net .
2021-08-02 13:02:54 +02:00
e61888dfe2
ace.js: Don't use srcdoc when creating iframes (see #4975 )
...
Using srcdoc, especially with multiple nested iframes, seems to be
problematic when using `self` in CSP policies.
2021-07-30 03:51:57 -04:00
9fda5adcef
ace2_inner.js: Improve discovery of `sidediv` and `linemetricsdiv`
...
The `Node.nextSibling` property returns the next Node, not the next
Element. If whitespace, an HTML comment, or any other type of
non-Element Node is ever introduced between the Elements then
`.nextSibling` no longer returns the desired Element. Switching to
`Element.nextElementSibling` would work, but finding the Elements by
ID is more readable and future-proof.
2021-07-30 03:51:56 -04:00
0c963a817a
ace2_inner.js: Delete unnecessary `ace_outerWin` variable
2021-07-30 03:51:56 -04:00
8d869ec927
Pad: Delete non-functional debug logging facility
2021-07-30 03:50:23 -04:00
5d39a57507
Pad: Delete dead `ace_getFormattedCode()`
2021-07-30 03:49:35 -04:00
c3af70e5a5
deps: Bump ueberdb2 to 1.4.13
2021-07-30 03:48:36 -04:00
2dbcd00dc6
Localisation updates from https://translatewiki.net .
2021-07-29 13:03:26 +02:00
a9c6ed8701
Localisation updates from https://translatewiki.net .
2021-07-26 13:03:49 +02:00
d723270388
tests: Improve readability of `multipleUsers.js`
...
* Define utility functions above their use to silence lint warnings.
* Use `.css()` instead of `.attr('style')` to manipulate style.
* Pass an object to `.attr()` rather than call once per attribute.
* Take advantage of chaining.
* Inline unnecessary `padUrl` variable.
* Delete some unnecessary comments.
2021-07-25 02:23:50 +02:00
ff39eeafca
tests: Factor out duplicate `getFrameJQuery()`
2021-07-25 02:23:50 +02:00
42026ff771
tests: Add a comment explaining why `Promise.all()` is not used
2021-07-25 02:23:50 +02:00
01184cd1aa
tests: Remove unnecessary `includeJquery` parameter
2021-07-25 02:23:50 +02:00
4a670e96ab
fix: upgrade express-rate-limit from 5.2.6 to 5.3.0
...
Snyk has created this PR to upgrade express-rate-limit from 5.2.6 to 5.3.0.
See this package in npm:
https://www.npmjs.com/package/express-rate-limit
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-07-23 04:22:23 +00:00
c83bb058d1
PadMessageHandler: Fix stats null dereference
...
It is possible for the stats to be read before the
`expressCreateServer` hook is called (in particular: when there is an
error during startup), which is when the `socketio` variable is set.
Check for non-null `socketio` before attempting to count the number of
socket.io connections.
2021-07-22 13:07:03 -04:00
3d80409236
Localisation updates from https://translatewiki.net .
2021-07-22 13:03:00 +02:00
62093adce5
tests: refactor inclusion of jquery and sendkeys via script tags
...
Readability is increased by explicitly checking if jquery/sendkeys was
already loaded before evaluating it in the context of ace_inner and the
enclosing container (pad.html). Note that sendkeys is no longer
evaluated in the context of ace_outer, as this isn't needed
Also removes some IE 8/9 legacy code
2021-07-21 01:53:05 +02:00
4ceb3ca4c8
Chat: Allow Shift-Enter to insert a newline
2021-07-19 23:44:33 +02:00
cf86ae8b63
Chat: Use `KeyboardEvent.key` instead of deprecated `.which`
2021-07-19 23:44:33 +02:00
faf84f0143
Chat: Display whitespace in chat messages
2021-07-19 23:44:33 +02:00
834e05fc9c
Chat: Use a `<textarea>` for message input
2021-07-19 23:44:33 +02:00
ce5ef9350f
tests: sendkeys: Fix `{enter}` keypress event
2021-07-19 23:44:33 +02:00
c6f643dd75
Localisation updates from https://translatewiki.net .
2021-07-19 13:02:46 +02:00
ca4cc2d7c0
Fix settings.useMonospaceFontGlobal
...
When settings.useMonospaceFontGlobal is set to `true`, it sets the default
font to 'monospace'. This font seems to have been removed in
a5164dad43
2021-07-14 04:33:38 -04:00
336d48add7
Add support for square brackets in URLs
...
This reverts commit 9022877cc6
2021-07-10 22:22:31 -04:00
09f8ffbdb6
deps: Bump ueberdb2 to 1.4.11
2021-07-10 18:26:31 -04:00
5f39a1ee7f
CSS: Underline links in error dialogs
...
Underlining was removed for unknown reasons by commit
d872b42e31
2021-07-09 18:43:13 -04:00
a634bd8ee1
bump version
2021-07-04 07:05:34 +02:00
197e04ecd7
Localisation updates from https://translatewiki.net .
2021-07-01 13:42:31 +02:00
3d40ab7e8c
CSS: Move author color padding to `setAuthorStyle()`
...
This prevents the padding from clashing with plugins that use the
`aceSetAuthorStyle` hook.
2021-06-22 14:43:22 -04:00
2745557127
Localisation updates from https://translatewiki.net .
2021-06-21 12:28:27 +02:00
9fcd86b3cd
Pad: Fix `<script>` elements in `aceInitInnerdocbodyHead` hook
...
Using `.innerHTML` to create a `<script>` element does create a DOM
node, but the script is not actually executed. Fortunately, creating a
DocumentFragment does cause the script to execute.
2021-06-18 17:50:15 -04:00
7bdd0f2f09
bin/updatePlugins.sh: Many refinements
...
* cd to top-level Etherpad directory is now more robust.
* Only attempt to update packages whose names begin with `ep_`.
* Don't create `package-lock.json`.
* Improve logging.
* Improve error handling.
2021-06-18 04:34:37 -04:00
4b3e47bd23
bin/importSqlFile.js: Read the file one line at a time
...
This avoids running out of memory if the file is large.
2021-06-17 19:45:17 -04:00
485538bd79
bump wtfnode to fix #5078
2021-06-17 06:14:45 +02:00
251cc7ab32
CSS: Fix button icon centering
2021-06-16 18:27:52 -04:00
53cca5a743
PadMessageHandler: Also send `USER_NEWINFO` messages on reconnect
...
Now the user list is correct after a reconnect. This also allows
ep_webrtc to automatically recover after a temporary network glitch.
2021-06-16 01:35:25 -04:00
7ca336c28e
lint: Update eslint-config-etherpad and friends
2021-06-14 23:17:17 +02:00
ef1ba21104
deps: Drop support for Node.js < 12.13.0
2021-06-14 23:17:17 +02:00
66ee9c5ef9
update package-lock
2021-06-14 13:21:48 -04:00
5dcb7a7549
tests: Don't attempt to wrap non-functions
2021-06-14 13:45:13 +02:00
081b97c41d
tests: Wrap more Mocha functions
2021-06-14 13:45:13 +02:00
3e4df68510
tests: Enable fake webcam on Microsoft Edge
2021-06-10 15:36:35 -04:00
565b1c5271
tests: Fix flexbox grow/shrink factors
...
* Make sure the `#mocha-report` div grows to fill the available
vertical space.
* Prevent the "Loading frontend test specs..." div from shrinking.
2021-06-10 13:28:55 -04:00
acd11c3948
tests: Fetch frontend test specs in parallel
2021-06-09 20:28:03 -04:00
36d2af5318
tests: Display frontend spec loading progress
2021-06-09 20:18:22 -04:00
e0ae997501
tests: Don't auto-scroll Mocha results if user scrolls up
2021-06-09 18:48:31 -04:00
f5046f4b18
tests: Keep the `#mocha-stats` div visible
2021-06-09 18:48:31 -04:00
ea4500ef64
fix: upgrade express-session from 1.17.1 to 1.17.2
...
Snyk has created this PR to upgrade express-session from 1.17.1 to 1.17.2.
See this package in npm:
https://www.npmjs.com/package/express-session
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-06-09 22:13:02 +00:00
28f2acf98a
Localisation updates from https://translatewiki.net .
2021-06-07 14:48:08 +02:00
cccabf45b8
pad: Move error message to the top of the gritter box
2021-06-06 21:31:49 -04:00
b2e94685fb
pad: Display error name in the gritter box
2021-06-06 21:31:40 -04:00
63a5dc6599
tests: Configure Firefox to use fake webcam
...
This makes it possible to test ep_webrtc in Firefox.
2021-06-06 16:53:51 -04:00
8f0d70312d
tests: Also pass `--use-fake-ui-for-media-stream` to Chrome
...
For testing ep_webrtc.
2021-06-06 16:25:27 -04:00
752e2488af
tests: Migrate from `wd` to `selenium-webdriver`
2021-06-06 16:23:56 -04:00
1756415495
tests: Avoid jQuery when reading Mocha output
2021-06-06 16:20:13 -04:00
6c2f31a5cb
tests: Add tests for `settings.json` parsing
2021-06-06 14:00:52 -04:00
428f8d1684
Settings: Deprecate null as the default default value
2021-06-06 14:00:52 -04:00
c7bb18c6da
Settings: Support null and undefined env var substitutions
2021-06-06 14:00:51 -04:00
299dbbe7e6
tests: Move split-grid to dev dependencies
...
This is only used for testing.
2021-06-06 06:45:00 -04:00
45ca82fd9f
tests: Make the Mocha results area resizable
2021-06-05 03:51:55 -04:00
c4239b6059
tests: Show a scrollbar if the pad is too wide
2021-06-05 03:51:11 -04:00
fc3b811726
tests: Move iframe min width to iframe selector
2021-06-05 03:51:11 -04:00
960c2c0c0d
tests: Tweak mocha report spacing
2021-06-05 03:51:11 -04:00
b09b895ac7
tests: Remove border around iframe
2021-06-05 03:51:11 -04:00
e9f08bdd11
tests: Fix frontend test CSS selectors
2021-06-05 03:51:11 -04:00
76634eb6ff
tests: Add missing `<head>` and `<body>` tags
2021-06-05 03:51:11 -04:00
d9782ac628
tests: Send frontend test spec list as JSON
2021-06-05 03:51:06 -04:00
20df34bb67
tests: Promisify `helper.init()`
2021-06-05 03:50:36 -04:00
c714ff1014
tests: Let Express handle errors when serving `frontendTestSpecs.js`
...
Express v4.x doesn't understand Promises so we have to manually catch
Promise rejections and pass the error object to `next()`.
2021-06-05 03:50:36 -04:00
e4f011df76
tests: Use `require()` to load frontend test specs
...
This makes core and plugin tests consistent with each other, makes it
possible to `require()` relative paths in spec files, simplifies the
code somewhat, and should make it easier to move away from
require-kernel.
Also:
* Wrap plugin tests inside a `describe()` that contains the plugin
name to make it easier to grep for a plugin's tests and for
consistency with core tests.
* Add "<core>" to the core test descriptions to make it easier to
distinguish them from plugin tests.
2021-06-05 03:50:26 -04:00
d8eb79428f
tests: Recurse under frontend spec dir
2021-06-05 03:49:13 -04:00
5d54c1657a
tests: Redirect `/tests/frontend/index.html` to `/tests/frontend/`
2021-06-05 03:49:12 -04:00
712b8c5769
tests: Redirect `/tests/frontend` to `/tests/frontend/`
2021-06-05 03:49:12 -04:00
573da027e5
tests: Preserve query string when redirecting
2021-06-05 03:49:12 -04:00
9cba96e5e9
tests: Use relative paths for scripts
2021-06-05 03:49:12 -04:00
e144434571
tests: Use relative paths in `helper.init()`
...
This avoids problems if Etherpad is served under a path like
`/etherpad`.
2021-06-05 03:49:12 -04:00
dfd649dbe9
tests: Use a relative redirect for `/tests/frontend`
...
This avoids problems if Etherpad is served under a path like
`/etherpad`.
2021-06-03 15:10:23 -04:00
617267ce71
tests: Use `plugin_defs` to get plugin frontend test spec paths
2021-06-03 15:10:23 -04:00
1b7b96f57e
tests: Avoid deprecated `fs.existsSync()`
2021-06-03 15:10:23 -04:00
ab824c728f
tests: Move slashes to improve readability
2021-06-03 15:10:22 -04:00
1516bf473f
tests: Delete unnecessary `staticDir` variable
2021-06-03 15:10:22 -04:00
d69345bb4e
tests: Use map+reduce to improve readability
2021-06-03 15:10:22 -04:00
a8e77126e8
tests: Combine `.map().filter().map()` into single `.map()`
2021-06-03 15:10:22 -04:00
2414203434
tests: Remove unnecessary `return`
2021-06-03 15:10:22 -04:00
0852df74f1
tests: Unexport unnecessarily exported functions
2021-06-03 15:10:22 -04:00
ed44449639
tests: Pretty-print `frontendTestSpecs.js` to make troubleshooting easier
2021-06-03 15:10:22 -04:00
4fa9f9e9d8
tests: Use `window.foo` instead of `var foo`
2021-06-03 15:10:22 -04:00
aea2fb7448
tests: Rename `specs_list` to `frontendTestSpecs`
2021-06-03 15:10:22 -04:00
1be1b704f1
tests: Simplify iteration over frontend test specs
2021-06-03 15:10:22 -04:00
b85a040f13
tests: Reuse `sanitizePathname` when serving frontend specs
2021-06-03 15:10:22 -04:00
ade17490e0
tests: Combine frontend test file handlers
2021-06-03 15:10:22 -04:00
995e381243
tests: Only wrap `*.js` files in `describe()`
2021-06-03 15:10:22 -04:00
e1c2c963f0
tests: URL decode test spec pathnames
...
Express automatically URL decodes route parameters.
2021-06-03 15:10:22 -04:00
998e77ec25
tests: Switch to promisified `readFile`
2021-06-03 15:10:22 -04:00
6cf27a7133
tests: Use `fs.promises` instead of wrapping with `util.promisify`
2021-06-03 15:10:22 -04:00
f00f9aa14c
tests: Avoid `.then()` inside `async` functions
2021-06-03 15:10:22 -04:00
d87b4e0c20
tests: Use `async`/`await` instead of returning Promises
...
This makes stack traces more useful.
2021-06-03 15:10:21 -04:00
0d9476529e
sanitizePathname: Move to separate module to facilitate reuse
2021-06-03 15:10:21 -04:00
926da57e34
Minify: Refine `sanitizePathname` to avoid pathname traversal
2021-06-03 15:10:21 -04:00
3bca85286b
Localisation updates from https://translatewiki.net .
2021-06-03 15:12:59 +02:00
8f63671ea9
Localisation updates from https://translatewiki.net .
2021-05-31 10:02:43 +02:00
a04089636c
Localisation updates from https://translatewiki.net .
2021-05-27 15:37:31 +02:00
c426e939d1
Localisation updates from https://translatewiki.net .
2021-05-24 14:00:35 +02:00
6f2f20233f
lint: Fix straightforward ESLint errors
2021-05-12 11:26:35 +02:00
59c03bde20
lint: Re-run `eslint --fix`
2021-05-12 11:26:35 +02:00
30eadad79d
lint: Bump ESLint dependencies
2021-05-12 11:26:35 +02:00
24929d3417
package.json: bump npm from 6.14.11 to 6.14.13
2021-05-07 14:58:57 +02:00
10f00906f8
update package-lock.json
2021-05-07 14:58:57 +02:00
ff245dbbeb
fix: upgrade underscore from 1.13.0 to 1.13.1
...
Snyk has created this PR to upgrade underscore from 1.13.0 to 1.13.1.
See this package in npm:
https://www.npmjs.com/package/underscore
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-05-07 14:27:30 +02:00
4701cc43fa
Localisation updates from https://translatewiki.net .
2021-05-07 10:50:38 +02:00
b040ebf419
Revert "PadMessageHandler: Use a `Map` for `sessioninfos`"
...
Switching to a Map broke ep_webrtc and maybe other plugins.
This reverts commit eeead46437
2021-05-05 18:09:10 -04:00
3c087af038
caretPosition: fix loading when iframe is hidden
2021-05-04 23:56:13 +02:00
8baacd514e
remote_runner: Always call `browser.quit()`
2021-05-03 01:48:08 -04:00
081f739a8d
remote_runner: Update browser list
...
Use latest versions of Chrome, Firefox, Safari, and Edge. Keep the old
Chrome version.
2021-05-03 01:48:08 -04:00
a7cd0a4b25
remote_runner: Avoid re-sending the same console text over and over
2021-05-03 01:48:08 -04:00
25275f2744
remote_runner: Treat no text as 0 lines, not 1 empty line
2021-05-03 01:48:08 -04:00
a17556b876
remote_runner: Avoid searching the full text for "FINISHED"
2021-05-03 01:48:08 -04:00
Richard Hansen
webzwo0i
snyk-bot
translatewiki.net
John McLear
Hossein
Volker Bijewitz
Xavier Mehrenberger